added default protocol for buildUrl method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm no longer using/maintaining this library. If you would like to take over maintaining this library, let me know what your npm user name is and I'll add you as an owner on npm so you can publish new versions. For this specific issue, not having a default protocol is fine. It currently defaults to using protocol relative URLs, so if you use those URLs in the browser, it will select either the https version or the http version depending on whether the current page was served over https. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the protocol is not passed in options, the generated url from buildUrl does not contain any protocol. This checkin assigns a default protocol (https) in the buildUrl method.